Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to test the crunchy deployer action by modifying CI workflow configuration.
- Commented out trigger settings in the pr-open workflow to potentially disable automatic triggers.
- Updated the deployer-db job to reference a remote workflow from the quickstart-openshift-helpers repository.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/pr-open.yml | Commented out triggers to adjust CI trigger configuration. |
| .github/workflows/.deployer.yml | Updated the job to use a remote workflow reference for deployment. |
DerekRoberts
force-pushed
the
chore/crunchyAction
branch
from
e2b37fa to
268d590
Compare
DerekRoberts
force-pushed
the
chore/crunchyAction
branch
from
103a541 to
b1a25a4
Compare
DerekRoberts
force-pushed
the
chore/crunchyAction
branch
2 times, most recently
from
5ca3eb7 to
61bebb2
Compare
Signed-off-by: Om Mishra <32200996+mishraomp@users.noreply.github.com>
Signed-off-by: Om Mishra <32200996+mishraomp@users.noreply.github.com>
Signed-off-by: Om Mishra <32200996+mishraomp@users.noreply.github.com>
Collaborator
|
@DerekRoberts it is in a good shape now, I think we can run the crunchy action in parallel while images are getting build, it will speed up the pipeline. |
mishraomp
reviewed
May 9, 2025
DerekRoberts
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the deployment configuration for the Crunchy PostgreSQL cluster and streamlines related workflows. Key changes include:
- Updating chart values for PostgreSQL and storage settings in charts/crunchy/values.yml.
- Enhancing secret retrieval logic in charts/app/templates/secret.yaml.
- Replacing custom removal commands with the bcgov/action-crunchy action in the pr-close workflow and updating deployment steps in .github/workflows/.deployer.yml.
Reviewed Changes
Copilot reviewed 5 out of 12 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/crunchy/values.yml | Updated PostgreSQL version and adjusted storage size and postGISVersion formatting. |
| charts/app/templates/secret.yaml | Modified secret naming logic and added explicit lookup validations. |
| .github/workflows/pr-close.yml | Replaced manual DB user removal steps with the new bcgov/action-crunchy action. |
| .github/workflows/.deployer.yml | Updated deployment steps to use the new crunchy action and added a debugging step. |
Files not reviewed (7)
- .github/workflows/.deployer-db.yml: Language not supported
- backend/package.json: Language not supported
- charts/crunchy/Chart.yaml: Language not supported
- charts/crunchy/templates/PostgresCluster.yaml: Language not supported
- charts/crunchy/templates/_helpers.tpl: Language not supported
- charts/crunchy/templates/knp.yaml: Language not supported
- charts/crunchy/templates/secret.yaml: Language not supported
Comments suppressed due to low confidence (1)
charts/crunchy/values.yml:8
- The postGISVersion value was changed from a quoted string to an unquoted numerical value. Please confirm that this type change is intentional and compatible with downstream processing.
postGISVersion: 3.4
mishraomp
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: